Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653
Committed: https://crrev.com/07dceb76cfef62e581b2f9bb9c25b41746af07fc
Cr-Commit-Position: refs/heads/master@{#423101}

[Prashant.Patil, 2016-10-03 10:58:23]

Description was changed from

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse
- multiply

R=kbr@chromium.org
BUG=642653
==========

to

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse
- multiply

R=kbr@chromium.org
BUG=642653
==========

[Prashant.Patil, 2016-10-03 10:58:23]

prashant.patil@imgtec.com changed reviewers:
+ dpranke@chromium.org, schenney@chromium.org, zmo@chromium.org

[Prashant.Patil, 2016-10-03 11:51:11]

Description was changed from

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse
- multiply

R=kbr@chromium.org
BUG=642653
==========

to

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 4x)

R=kbr@chromium.org
BUG=642653
==========

[Prashant.Patil, 2016-10-03 11:55:06]

Description was changed from

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 4x)

R=kbr@chromium.org
BUG=642653
==========

to

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653
==========

[Ken Russell (switch to Gerrit), 2016-10-03 20:28:11]

kbr@chromium.org changed reviewers:
+ alancutter@chromium.org, pdr@chromium.org, suzyh@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-03 20:28:11]

Thanks for this contribution. What kind of testing has been done on this new
code?

Maybe pdr, suzyh, or alancutter could review this? It looks like suzyh added a
unit test for this code not that long ago. Has it been run?

[suzyh_UTC10 (ex-contributor), 2016-10-04 02:14:13]

I don't believe I can be a useful reviewer for this code, other than to
recommend that you make sure that there are unit tests for these functions that
are running regularly on bots that exercise each alternative implementation.
(And not just that there is a bot for the new implementation, but that no other
implementation has now become untested.)

[suzyh_UTC10 (ex-contributor), 2016-10-04 02:14:26]

suzyh@chromium.org changed reviewers:
- suzyh@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-04 02:16:24]

On 2016/10/04 02:14:13, suzyh wrote:
> I don't believe I can be a useful reviewer for this code, other than to
> recommend that you make sure that there are unit tests for these functions
that
> are running regularly on bots that exercise each alternative implementation.
> (And not just that there is a bot for the new implementation, but that no
other
> implementation has now become untested.)

Thanks for your feedback -- any pointers on the unit tests you added for this
code in case the submitter hasn't run them?

I don't think the Chromium project will be adding MIPS bots -- it's MIPS'
responsibility to make sure this code works.

[Prashant.Patil, 2016-10-04 13:28:17]

On 2016/10/04 02:16:24, Ken Russell wrote:
> On 2016/10/04 02:14:13, suzyh wrote:
> > I don't believe I can be a useful reviewer for this code, other than to
> > recommend that you make sure that there are unit tests for these functions
> that
> > are running regularly on bots that exercise each alternative implementation.
> > (And not just that there is a bot for the new implementation, but that no
> other
> > implementation has now become untested.)
> 
> Thanks for your feedback -- any pointers on the unit tests you added for this
> code in case the submitter hasn't run them?
> 
> I don't think the Chromium project will be adding MIPS bots -- it's MIPS'
> responsibility to make sure this code works.

We have tested these functions locally for mips and will take care of
maintaining it.

[Ken Russell (switch to Gerrit), 2016-10-05 00:04:55]

OK. LGTM

[Prashant.Patil, 2016-10-05 06:05:36]

The CQ bit was checked by prashant.patil@imgtec.com

[commit-bot: I haz the power, 2016-10-05 06:05:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 07:40:36]

Description was changed from

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653
==========

to

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653
==========

[commit-bot: I haz the power, 2016-10-05 07:40:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 07:42:17]

Description was changed from

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653
==========

to

==========
Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG=642653

Committed: https://crrev.com/07dceb76cfef62e581b2f9bb9c25b41746af07fc
Cr-Commit-Position: refs/heads/master@{#423101}
==========

[commit-bot: I haz the power, 2016-10-05 07:42:18]

Patchset 1 (id:??) landed as
https://crrev.com/07dceb76cfef62e581b2f9bb9c25b41746af07fc
Cr-Commit-Position: refs/heads/master@{#423101}