Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2392483002: Prune createVisibleSelectionDeprecated from svg (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from svg SVGTextContentElement::selectSubString calls VisiblePosition::firstPositionInNode, which updates layout and thus ensures clean layout for the later call of createVisibleSelectionDeprecated. Hence, this patch safely prunes this call of createVisibleSelectionDeprecated. BUG=651373 Committed: https://crrev.com/666af71049d1b77a81ba9c15da70da466fdc6abd Cr-Commit-Position: refs/heads/master@{#422389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 06:44:24 UTC) #4
tkent
Would you explain why we can prune it in the CL description please?
4 years, 2 months ago (2016-10-03 07:59:32 UTC) #7
Xiaocheng
On 2016/10/03 at 07:59:32, tkent wrote: > Would you explain why we can prune it ...
4 years, 2 months ago (2016-10-03 08:05:57 UTC) #9
tkent
lgtm
4 years, 2 months ago (2016-10-03 08:08:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392483002/1
4 years, 2 months ago (2016-10-03 08:13:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 08:18:25 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 08:20:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/666af71049d1b77a81ba9c15da70da466fdc6abd
Cr-Commit-Position: refs/heads/master@{#422389}

Powered by Google App Engine
This is Rietveld 408576698