Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Issue 2392473002: Prune createVisibleSelectionDeprecated from EditingUtilities (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from EditingUtilities BUG=651373 Committed: https://crrev.com/6315b606245d979e4a0948bb490b2eee6b9ec41f Cr-Commit-Position: refs/heads/master@{#422381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 06:30:22 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 06:45:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392473002/1
4 years, 2 months ago (2016-10-03 06:57:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 07:02:25 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 07:04:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6315b606245d979e4a0948bb490b2eee6b9ec41f
Cr-Commit-Position: refs/heads/master@{#422381}

Powered by Google App Engine
This is Rietveld 408576698