Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2392463004: reflow comments in modules/{webmidi,websocket} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, haraken, tyoshino+watch_chromium.org, toyoshim+midi_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/{webmidi,websocket} BUG=563793 Committed: https://crrev.com/576dc3cfcba01528ddf5739342a7f6f6109816d2 Cr-Commit-Position: refs/heads/master@{#422808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketHandle.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 2 months ago (2016-10-04 14:21:05 UTC) #3
yhirano
lgtm
4 years, 2 months ago (2016-10-04 14:22:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392463004/1
4 years, 2 months ago (2016-10-04 14:25:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 15:37:59 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:40:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/576dc3cfcba01528ddf5739342a7f6f6109816d2
Cr-Commit-Position: refs/heads/master@{#422808}

Powered by Google App Engine
This is Rietveld 408576698