Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp

Issue 2392443009: reflow comments in core/paint (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp b/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
index 37593fb895ec9105d4a2eac446c1986ddaf16f9b..bb89345b3815c063b378db8df060325bcab14107 100644
--- a/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
@@ -22,10 +22,11 @@ void MultiColumnSetPainter::paintObject(const PaintInfo& paintInfo,
BlockPainter(m_layoutMultiColumnSet).paintObject(paintInfo, paintOffset);
// FIXME: Right now we're only painting in the foreground phase.
- // Columns should technically respect phases and allow for background/float/foreground overlap etc., just like
- // LayoutBlocks do. Note this is a pretty minor issue, since the old column implementation clipped columns
- // anyway, thus making it impossible for them to overlap one another. It's also really unlikely that the columns
- // would overlap another block.
+ // Columns should technically respect phases and allow for
+ // background/float/foreground overlap etc., just like LayoutBlocks do. Note
+ // this is a pretty minor issue, since the old column implementation clipped
+ // columns anyway, thus making it impossible for them to overlap one another.
+ // It's also really unlikely that the columns would overlap another block.
if (!m_layoutMultiColumnSet.flowThread() ||
(paintInfo.phase != PaintPhaseForeground &&
paintInfo.phase != PaintPhaseSelection))

Powered by Google App Engine
This is Rietveld 408576698