Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2392443003: Add MSA (MIPS SIMD Arch) optimized color conversion functions (Closed)

Created:
4 years, 2 months ago by Prashant.Patil
Modified:
4 years, 2 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, raghu.gandham_imgtec.com, gordana.cmiljanovic_imgtec.com, manojkumar.bhosale, parag.salasakar_imgtec.com, kaustubh.raste_imgtec.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MSA (MIPS SIMD Arch) optimized color conversion functions We add following MSA optimized WebGL color conversion functions - - packOneRowOfRGBA8ToUnsignedShort4444MSA (Gain 8x) - packOneRowOfRGBA8LittleToR8MSA (Gain 3.5x) - packOneRowOfRGBA8LittleToRA8MSA (Gain 4x) R=kbr@chromium.org BUG=642653 Committed: https://crrev.com/cf80638fb01383b66356beda41e32fb1318cc23a Cr-Commit-Position: refs/heads/master@{#423098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/cpu/mips/CommonMacrosMSA.h View 8 chunks +142 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/cpu/mips/WebGLImageConversionMSA.h View 1 chunk +430 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Prashant.Patil
4 years, 2 months ago (2016-10-03 08:21:30 UTC) #1
Prashant.Patil
4 years, 2 months ago (2016-10-03 08:26:45 UTC) #4
Ken Russell (switch to Gerrit)
LGTM assuming MIPS has tested this code and will maintain it.
4 years, 2 months ago (2016-10-05 01:28:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392443003/1
4 years, 2 months ago (2016-10-05 05:35:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 07:21:42 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf80638fb01383b66356beda41e32fb1318cc23a Cr-Commit-Position: refs/heads/master@{#423098}
4 years, 2 months ago (2016-10-05 07:24:20 UTC) #12
qiankun
Hi Prashant, How did you measure the speedup? Which benchmark or test did you use? ...
4 years, 2 months ago (2016-10-09 11:16:42 UTC) #14
Prashant.Patil
On 2016/10/09 11:16:42, qiankun wrote: > Hi Prashant, > > How did you measure the ...
4 years, 2 months ago (2016-10-12 09:33:21 UTC) #15
qiankun
4 years, 2 months ago (2016-10-12 10:04:29 UTC) #16
Message was sent while issue was closed. 
On 2016/10/12 09:33:21, Prashant.Patil wrote:
> On 2016/10/09 11:16:42, qiankun wrote:
> > Hi Prashant,
> > 
> > How did you measure the speedup? Which benchmark or test did you use? I am
> > planning to add SIMD optimization for x86 platform. Do unittests in
> > WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp cover full
> > functional tests? Or it is covered by WebGL conformance test?
> > 
> > Thanks,
> > Qiankun
> 
> The WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp convers
the
> functional/compliance tests for color format conversions (Only 9 cases are
> covered till now. You can add more tests if you want to add platform
> implementation of functions other than these)
> 
> The speedup is measured using plaform specific local test suite.
> 
> Regards,
> Prashant

I see. Thank you!

Powered by Google App Engine
This is Rietveld 408576698