Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2392433003: DevTools: Catch async errors in unit tests (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Catch async errors in unit tests This prevents tests from timing out if they throw an error. BUG=none Committed: https://crrev.com/4bda9631249437632070c20e6a31bb10c0cc608e Cr-Commit-Position: refs/heads/master@{#422481}

Patch Set 1 #

Patch Set 2 : Add a test #

Patch Set 3 : Style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/test-failure.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector-unit/test-failure-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-03 17:55:15 UTC) #3
dgozman
lgtm
4 years, 2 months ago (2016-10-03 18:13:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392433003/40001
4 years, 2 months ago (2016-10-03 18:56:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 19:05:37 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:07:30 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4bda9631249437632070c20e6a31bb10c0cc608e
Cr-Commit-Position: refs/heads/master@{#422481}

Powered by Google App Engine
This is Rietveld 408576698