src/liveedit.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index 4a6fe731a6ef3eb1b2bd09cebf0b3f7d97c8693c..d0eab5bfb6ebea3758e801772ff09dd7ae96780c 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1888,8 +1888,8 @@ Handle<JSArray> LiveEdit::CheckAndDropActivations(

DropActivationsInActiveThread(shared_info_array, result, do_drop);

if (error_message != NULL) {

// Add error message as an array extra element.

- Handle<String> str = isolate->factory()->NewStringFromAscii(

- CStrVector(error_message));

+ Handle<String> str =

+ isolate->factory()->NewStringFromAsciiChecked(error_message);

SetElementSloppy(result, len, str);

}

return result;

« no previous file with comments | « src/jsregexp.cc ('k') | src/parser.cc » ('j') | no next file with comments »