src/debug.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 4c53e197b9e06329821653c8d320dc84ea93e9f1..c2d324e502589acb7391972d1c67e4753170b232 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -753,8 +753,8 @@ bool Debug::CompileDebuggerScript(Isolate* isolate, int index) {

Handle<String> source_code =

isolate->bootstrapper()->NativesSourceLookup(index);

Vector<const char> name = Natives::GetScriptName(index);

- Handle<String> script_name = factory->NewStringFromAscii(name);

- ASSERT(!script_name.is_null());

+ Handle<String> script_name =

+ factory->NewStringFromAscii(name).ToHandleChecked();

Handle<Context> context = isolate->native_context();

// Compile the script.

« no previous file with comments | « src/d8.cc ('k') | src/factory.h » ('j') | no next file with comments »