src/d8.cc - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 4e14cd5b0aa65f1607f3b2a9491f3970a4e95095..99be8613bef3255c36264131487aee13b2f901b0 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -982,7 +982,7 @@ Local<Context> Shell::CreateEvaluationContext(Isolate* isolate) {

factory->NewFixedArray(js_args.argc);

for (int j = 0; j < js_args.argc; j++) {

i::Handle<i::String> arg =

- factory->NewStringFromUtf8(i::CStrVector(js_args[j]));

+ factory->NewStringFromUtf8(i::CStrVector(js_args[j])).ToHandleChecked();

Igor Sheludko 2014/04/17 12:59:03 Not sure about this place, can it fail here?

Yang 2014/04/17 13:00:15 Very unlikely I guess.

arguments_array->set(j, *arg);

}

i::Handle<i::JSArray> arguments_jsarray =

« no previous file with comments | « src/contexts.cc ('k') | src/debug.cc » ('j') | src/factory.h » ('J')