Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/liveedit.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/jsregexp.cc ('k') | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1870 matching lines...) Expand 10 before | Expand all | Expand 10 after
1881 &inactive_threads_checker); 1881 &inactive_threads_checker);
1882 if (inactive_threads_checker.HasBlockedFunctions()) { 1882 if (inactive_threads_checker.HasBlockedFunctions()) {
1883 return result; 1883 return result;
1884 } 1884 }
1885 1885
1886 // Try to drop activations from the current stack. 1886 // Try to drop activations from the current stack.
1887 const char* error_message = 1887 const char* error_message =
1888 DropActivationsInActiveThread(shared_info_array, result, do_drop); 1888 DropActivationsInActiveThread(shared_info_array, result, do_drop);
1889 if (error_message != NULL) { 1889 if (error_message != NULL) {
1890 // Add error message as an array extra element. 1890 // Add error message as an array extra element.
1891 Handle<String> str = isolate->factory()->NewStringFromAscii( 1891 Handle<String> str =
1892 CStrVector(error_message)); 1892 isolate->factory()->NewStringFromAsciiChecked(error_message);
1893 SetElementSloppy(result, len, str); 1893 SetElementSloppy(result, len, str);
1894 } 1894 }
1895 return result; 1895 return result;
1896 } 1896 }
1897 1897
1898 1898
1899 // Describes a single callframe a target. Not finding this frame 1899 // Describes a single callframe a target. Not finding this frame
1900 // means an error. 1900 // means an error.
1901 class SingleFrameTarget { 1901 class SingleFrameTarget {
1902 public: 1902 public:
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 2002
2003 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2003 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2004 return false; 2004 return false;
2005 } 2005 }
2006 2006
2007 #endif // ENABLE_DEBUGGER_SUPPORT 2007 #endif // ENABLE_DEBUGGER_SUPPORT
2008 2008
2009 2009
2010 2010
2011 } } // namespace v8::internal 2011 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/jsregexp.cc ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698