Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: src/debug.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | src/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 735 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 746
747 // Bail out if the index is invalid. 747 // Bail out if the index is invalid.
748 if (index == -1) { 748 if (index == -1) {
749 return false; 749 return false;
750 } 750 }
751 751
752 // Find source and name for the requested script. 752 // Find source and name for the requested script.
753 Handle<String> source_code = 753 Handle<String> source_code =
754 isolate->bootstrapper()->NativesSourceLookup(index); 754 isolate->bootstrapper()->NativesSourceLookup(index);
755 Vector<const char> name = Natives::GetScriptName(index); 755 Vector<const char> name = Natives::GetScriptName(index);
756 Handle<String> script_name = factory->NewStringFromAscii(name); 756 Handle<String> script_name =
757 ASSERT(!script_name.is_null()); 757 factory->NewStringFromAscii(name).ToHandleChecked();
758 Handle<Context> context = isolate->native_context(); 758 Handle<Context> context = isolate->native_context();
759 759
760 // Compile the script. 760 // Compile the script.
761 Handle<SharedFunctionInfo> function_info; 761 Handle<SharedFunctionInfo> function_info;
762 function_info = Compiler::CompileScript(source_code, 762 function_info = Compiler::CompileScript(source_code,
763 script_name, 0, 0, 763 script_name, 0, 0,
764 false, 764 false,
765 context, 765 context,
766 NULL, NULL, NO_CACHED_DATA, 766 NULL, NULL, NO_CACHED_DATA,
767 NATIVES_CODE); 767 NATIVES_CODE);
(...skipping 2967 matching lines...) Expand 10 before | Expand all | Expand 10 after
3735 { 3735 {
3736 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3736 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3737 isolate_->debugger()->CallMessageDispatchHandler(); 3737 isolate_->debugger()->CallMessageDispatchHandler();
3738 } 3738 }
3739 } 3739 }
3740 } 3740 }
3741 3741
3742 #endif // ENABLE_DEBUGGER_SUPPORT 3742 #endif // ENABLE_DEBUGGER_SUPPORT
3743 3743
3744 } } // namespace v8::internal 3744 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698