Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: src/ast.cc

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1161 matching lines...) Expand 10 before | Expand all | Expand 10 after
1172 char arr[100]; 1172 char arr[100];
1173 Vector<char> buffer(arr, ARRAY_SIZE(arr)); 1173 Vector<char> buffer(arr, ARRAY_SIZE(arr));
1174 const char* str; 1174 const char* str;
1175 if (value_->IsSmi()) { 1175 if (value_->IsSmi()) {
1176 // Optimization only, the heap number case would subsume this. 1176 // Optimization only, the heap number case would subsume this.
1177 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value()); 1177 OS::SNPrintF(buffer, "%d", Smi::cast(*value_)->value());
1178 str = arr; 1178 str = arr;
1179 } else { 1179 } else {
1180 str = DoubleToCString(value_->Number(), buffer); 1180 str = DoubleToCString(value_->Number(), buffer);
1181 } 1181 }
1182 return isolate_->factory()->NewStringFromAscii(CStrVector(str)); 1182 return isolate_->factory()->NewStringFromAsciiChecked(str);
1183 } 1183 }
1184 1184
1185 1185
1186 } } // namespace v8::internal 1186 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698