Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 239243005: arm64_download script waits for VM to boot before finishing. (Closed)

Created:
6 years, 8 months ago by hal.canary
Modified:
6 years, 8 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

arm64_download script waits for VM to boot before finishing. It may take an unknown amount of time to boot. Also, add `set -e` to the script to simplify error handling. BUG=skia:2425 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14209

Patch Set 1 #

Total comments: 1

Patch Set 2 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M platform_tools/barelinux/bin/arm64_download View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hal.canary
PTAL. We now keep trying SSH until it fails.
6 years, 8 months ago (2014-04-15 19:26:31 UTC) #1
epoger
LGTM with a Dire Warning https://codereview.chromium.org/239243005/diff/1/platform_tools/barelinux/bin/arm64_download File platform_tools/barelinux/bin/arm64_download (right): https://codereview.chromium.org/239243005/diff/1/platform_tools/barelinux/bin/arm64_download#newcode9 platform_tools/barelinux/bin/arm64_download:9: set -e Note that ...
6 years, 8 months ago (2014-04-15 19:33:06 UTC) #2
hal.canary
On 2014/04/15 19:33:06, epoger wrote: > LGTM with a Dire Warning > > https://codereview.chromium.org/239243005/diff/1/platform_tools/barelinux/bin/arm64_download > ...
6 years, 8 months ago (2014-04-15 20:04:17 UTC) #3
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-15 20:04:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/239243005/20001
6 years, 8 months ago (2014-04-15 20:05:18 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 20:05:26 UTC) #6
Message was sent while issue was closed.
Change committed as 14209

Powered by Google App Engine
This is Rietveld 408576698