Issue 239243002: Remove RenderBlock::pushToNextPageWithMinimumLogicalHeight().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239243002: Remove RenderBlock::pushToNextPageWithMinimumLogicalHeight(). (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)

Modified:
6 years, 8 months ago

Reviewers:
ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove RenderBlock::pushToNextPageWithMinimumLogicalHeight(). It is currently never called, because we always have "uniform page height". If we would ever get non-uniform page height in the future, though, that method would do the wrong thing anyway, and prevent us from inserting breaks. So just get rid of it for now. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171686

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	Source/core/rendering/RenderBlock.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/rendering/RenderBlock.cpp	View		2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/239243002/1

6 years, 8 months ago (2014-04-15 18:54:05 UTC) #3

Message was sent while issue was closed.

Change committed as 171686

Expand Messages | Collapse Messages