sdk/lib/_internal/pub/lib/src/solver/version_solver.dart - Issue 23924006: Detect transformer dependency cycles in packages using barback transformers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

Issue 23924006: Detect transformer dependency cycles in packages using barback transformers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart ('K') | « sdk/lib/_internal/pub/lib/src/pubspec.dart ('k') | sdk/lib/_internal/pub/lib/src/utils.dart » ('j') | sdk/lib/_internal/pub/lib/src/utils.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

diff --git a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

index eb2fc63af90de8127d7e1bafd3004e8cda641a13..09d5fbf22fcbbed627df7da8e73121a58b2dcd6b 100644

--- a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

+++ b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

@@ -187,8 +187,7 @@ abstract class SolveFailure implements ApplicationException {

map[dep.depender] = dep.dep;

}

- var names = map.keys.toList();

- names.sort();

+ var names = ordered(map.keys);

buffer.writeAll(names.map(

(name) => "- '$name' ${_describeDependency(map[name])}"), '\n');