Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2392353002: Move table cell height flexing into a separate method. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move table cell height flexing into a separate method. TableSection::layoutRows() is long enough as it is. :) Committed: https://crrev.com/83bb0a47925aa540084e8c1a3536b7ccccdffebc Cr-Commit-Position: refs/heads/master@{#423248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -55 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 2 chunks +61 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-05 12:33:46 UTC) #2
dgrogan
lgtm
4 years, 2 months ago (2016-10-05 17:03:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392353002/1
4 years, 2 months ago (2016-10-05 17:03:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:22:09 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:25:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83bb0a47925aa540084e8c1a3536b7ccccdffebc
Cr-Commit-Position: refs/heads/master@{#423248}

Powered by Google App Engine
This is Rietveld 408576698