Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2392343004: Optimize out checkInt, checkNum and checkString (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +18 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
This removes a lot of irritating calls like: H.checkString("%3B");
4 years, 2 months ago (2016-10-07 20:58:23 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years, 2 months ago (2016-10-07 21:05:49 UTC) #4
sra1
4 years, 2 months ago (2016-10-07 22:18:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
0eae2630761402f98cca95380c9bebd0a024772c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698