third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)

Patch Set: include base/logging.h for NOTIMPLEMENTED Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index 5ce6d4dab8af802dfb2e2dc3a28748d4cb6bb684..a135654bc3b376a41ab5226e7d9324dc983e23f4 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -98,7 +98,8 @@ class ServiceWorkerGlobalScopeProxy final

void dispatchNotificationClickEvent(int,

const WebString& notificationID,

const WebNotificationData&,

- int actionIndex) override;

+ int actionIndex,

+ const WebString& reply) override;

void dispatchNotificationCloseEvent(int,

const WebString& notificationID,

const WebNotificationData&) override;