Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: include base/logging.h for NOTIMPLEMENTED Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 210bd3e154f0000e68da5c5c5f739bbcf81321a6..c840404783113ed14c29a5fef6f6f426af08b121 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -914,12 +914,14 @@ void ServiceWorkerContextClient::OnNotificationClickEvent(
int request_id,
const std::string& notification_id,
const PlatformNotificationData& notification_data,
- int action_index) {
+ int action_index,
+ const base::NullableString16& reply) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerContextClient::OnNotificationClickEvent");
proxy_->dispatchNotificationClickEvent(
request_id, blink::WebString::fromUTF8(notification_id),
- ToWebNotificationData(notification_data), action_index);
+ ToWebNotificationData(notification_data), action_index,
+ blink::WebString(reply));
}
void ServiceWorkerContextClient::OnNotificationCloseEvent(

Powered by Google App Engine
This is Rietveld 408576698