chrome/browser/notifications/non_persistent_notification_handler.cc - Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/non_persistent_notification_handler.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)

Patch Set: include base/logging.h for NOTIMPLEMENTED Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/non_persistent_notification_handler.h ('k') | chrome/browser/notifications/notification_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/non_persistent_notification_handler.cc

diff --git a/chrome/browser/notifications/non_persistent_notification_handler.cc b/chrome/browser/notifications/non_persistent_notification_handler.cc

index 3e21f926c3f27b7e4ec54d03c34dc953aadd7b9a..e2c5d876bc0bd82a105255565afb15df027b185f 100644

--- a/chrome/browser/notifications/non_persistent_notification_handler.cc

+++ b/chrome/browser/notifications/non_persistent_notification_handler.cc

@@ -25,9 +25,12 @@ void NonPersistentNotificationHandler::OnClick(

Profile* profile,

const std::string& origin,

const std::string& notification_id,

- int action_index) {

- // Buttons not supported for non persistent notifications.

+ int action_index,

+ const base::NullableString16& reply) {

+ // Buttons and replies not supported for non persistent notifications.

DCHECK_EQ(action_index, -1);

+ DCHECK(reply.is_null());

if (notifications_.find(notification_id) != notifications_.end()) {

notifications_[notification_id]->Click();

}