Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Send NullableString through IPC, remove settings check from ButtonClickWithReply, add TODO in messa… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index c28fcbe3e055dabba994a1fb3bb3e940044ecd19..a78a3b089e539e13150731e8e3e5d3ef0108496f 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -245,7 +245,8 @@ void ServiceWorkerGlobalScopeProxy::dispatchNotificationClickEvent(
int eventID,
const WebString& notificationID,
const WebNotificationData& data,
- int actionIndex) {
+ int actionIndex,
+ const WebString& reply) {
WaitUntilObserver* observer = WaitUntilObserver::create(
workerGlobalScope(), WaitUntilObserver::NotificationClick, eventID);
NotificationEventInit eventInit;
@@ -253,6 +254,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchNotificationClickEvent(
workerGlobalScope(), notificationID, data, true /* showing */));
if (0 <= actionIndex && actionIndex < static_cast<int>(data.actions.size()))
eventInit.setAction(data.actions[actionIndex].action);
+ eventInit.setReply(reply);
Event* event = NotificationEvent::create(EventTypeNames::notificationclick,
eventInit, observer);
workerGlobalScope()->dispatchExtendableEvent(event, observer);

Powered by Google App Engine
This is Rietveld 408576698