Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Send NullableString through IPC, remove settings check from ButtonClickWithReply, add TODO in messa… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/notifications/notification_event_dispatcher_impl.cc ('K') | « content/browser/notifications/notification_event_dispatcher_impl.cc ('k') | content/public/browser/notification_event_dispatcher.h » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/service_worker/service_worker_messages.h
diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h
index 01ca9418ba3188196f7f6e0ea622d663ebfb83ca..e07145f4376a836262f1ebb84a63e97c9a73c05b 100644
--- a/content/common/service_worker/service_worker_messages.h
+++ b/content/common/service_worker/service_worker_messages.h
@@ -487,11 +487,16 @@ IPC_MESSAGE_CONTROL1(ServiceWorkerMsg_ActivateEvent,
IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ExtendableMessageEvent,
int /* request_id */,
ServiceWorkerMsg_ExtendableMessageEvent_Params)
-IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,
+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_FetchEvent,
+ int /* response_id */,
+ int /* event_finish_id */,
+ content::ServiceWorkerFetchRequest)
Peter Beverloo 2016/10/12 13:58:31 bad merge?
awdf 2016/10/12 17:04:01 Oops, yes, I thought that it had been added in the
+IPC_MESSAGE_CONTROL5(ServiceWorkerMsg_NotificationClickEvent,
int /* request_id */,
std::string /* notification_id */,
content::PlatformNotificationData /* notification_data */,
- int /* action_index */)
+ int /* action_index */,
+ base::NullableString16 /* notification reply */)
IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationCloseEvent,
int /* request_id */,
std::string /* notification_id */,
« content/browser/notifications/notification_event_dispatcher_impl.cc ('K') | « content/browser/notifications/notification_event_dispatcher_impl.cc ('k') | content/public/browser/notification_event_dispatcher.h » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698