content/common/service_worker/service_worker_messages.h - Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)

Patch Set: Remove todo as it doesn't seem necessary after all Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 59af129dd12f5df863d18ace425eed15484abba0..8f83073ce469d70d8ae0be3c5cca603d500e872a 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -495,11 +495,12 @@ IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_FetchEvent,

int /* response_id */,

int /* event_finish_id */,

content::ServiceWorkerFetchRequest)

-IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,

+IPC_MESSAGE_CONTROL5(ServiceWorkerMsg_NotificationClickEvent,

int /* request_id */,

std::string /* notification_id */,

content::PlatformNotificationData /* notification_data */,

- int /* action_index */)

+ int /* action_index */,

+ base::string16 /* notification reply */)

IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationCloseEvent,

int /* request_id */,

std::string /* notification_id */,