Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2962)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Remove todo as it doesn't seem necessary after all Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 13d772aa8b6f804b64f1ee4669bdbab523af26d0..3339a832d2de47cbe09b1b028cc2f11c5c4c1b6e 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -9,6 +9,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics_action.h"
+#include "base/strings/nullable_string16.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
@@ -107,7 +108,8 @@ void PlatformNotificationServiceImpl::OnPersistentNotificationClick(
BrowserContext* browser_context,
const std::string& notification_id,
const GURL& origin,
- int action_index) {
+ int action_index,
+ const base::NullableString16& reply) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
blink::mojom::PermissionStatus permission_status =
CheckPermissionOnUIThread(browser_context, origin,
@@ -140,7 +142,7 @@ void PlatformNotificationServiceImpl::OnPersistentNotificationClick(
content::NotificationEventDispatcher::GetInstance()
->DispatchNotificationClickEvent(
- browser_context, notification_id, origin, action_index,
+ browser_context, notification_id, origin, action_index, reply,
base::Bind(
&PlatformNotificationServiceImpl::OnClickEventDispatchComplete,
base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698