Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2686)

Unified Diff: chrome/browser/notifications/persistent_notification_handler.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Remove todo as it doesn't seem necessary after all Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/persistent_notification_handler.cc
diff --git a/chrome/browser/notifications/persistent_notification_handler.cc b/chrome/browser/notifications/persistent_notification_handler.cc
index 810b0f1ea8ec00e0beaf36d6bc1983a1c20b78d1..f68c778ee3ac33b41c637dcfe64cf80ec816e983 100644
--- a/chrome/browser/notifications/persistent_notification_handler.cc
+++ b/chrome/browser/notifications/persistent_notification_handler.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/notifications/persistent_notification_handler.h"
#include "base/logging.h"
+#include "base/strings/nullable_string16.h"
#include "chrome/browser/notifications/platform_notification_service_impl.h"
#include "chrome/browser/profiles/profile.h"
@@ -25,15 +26,17 @@ void PersistentNotificationHandler::OnClose(Profile* profile,
profile, notification_id, notification_origin, by_user);
}
-void PersistentNotificationHandler::OnClick(Profile* profile,
- const std::string& origin,
- const std::string& notification_id,
- int action_index) {
+void PersistentNotificationHandler::OnClick(
+ Profile* profile,
+ const std::string& origin,
+ const std::string& notification_id,
+ int action_index,
+ const base::NullableString16& reply) {
const GURL notification_origin(origin);
DCHECK(notification_origin.is_valid());
PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClick(
- profile, notification_id, notification_origin, action_index);
+ profile, notification_id, notification_origin, action_index, reply);
}
void PersistentNotificationHandler::OpenSettings(Profile* profile) {

Powered by Google App Engine
This is Rietveld 408576698