Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: chrome/browser/notifications/native_notification_display_service.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Remove todo as it doesn't seem necessary after all Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/native_notification_display_service.cc
diff --git a/chrome/browser/notifications/native_notification_display_service.cc b/chrome/browser/notifications/native_notification_display_service.cc
index c09e118eddca61283a7cf00409ddb7467b19b405..2b0173205278e7a4de5e2ca2851edd1f9da811e2 100644
--- a/chrome/browser/notifications/native_notification_display_service.cc
+++ b/chrome/browser/notifications/native_notification_display_service.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/notifications/native_notification_display_service.h"
#include "base/memory/ptr_util.h"
+#include "base/strings/nullable_string16.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/notifications/non_persistent_notification_handler.h"
#include "chrome/browser/notifications/notification.h"
@@ -84,7 +85,8 @@ void NativeNotificationDisplayService::ProcessNotificationOperation(
CHECK(handler);
switch (operation) {
case NotificationCommon::CLICK:
- handler->OnClick(profile_, origin, notification_id, action_index);
+ handler->OnClick(profile_, origin, notification_id, action_index,
+ base::NullableString16());
Peter Beverloo 2016/10/11 14:22:56 nit: /* reply */
awdf 2016/10/12 10:44:57 Done.
break;
case NotificationCommon::CLOSE:
handler->OnClose(profile_, origin, notification_id, true /* by_user */);

Powered by Google App Engine
This is Rietveld 408576698