chrome/browser/notifications/non_persistent_notification_handler.cc - Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/non_persistent_notification_handler.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)

Patch Set: Pass the reply through from PNS -> SW so new test passes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/non_persistent_notification_handler.h ('k') | chrome/browser/notifications/notification_handler.h » ('j') | content/shell/browser/layout_test/layout_test_notification_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/non_persistent_notification_handler.cc

diff --git a/chrome/browser/notifications/non_persistent_notification_handler.cc b/chrome/browser/notifications/non_persistent_notification_handler.cc

index 3e21f926c3f27b7e4ec54d03c34dc953aadd7b9a..959cec0b25f74c59db622bdb9d60b0c63b3f59d3 100644

--- a/chrome/browser/notifications/non_persistent_notification_handler.cc

+++ b/chrome/browser/notifications/non_persistent_notification_handler.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/notifications/non_persistent_notification_handler.h"

+#include "base/strings/nullable_string16.h"

#include "chrome/browser/notifications/notification_delegate.h"

#include "chrome/browser/notifications/platform_notification_service_impl.h"

@@ -25,7 +26,8 @@ void NonPersistentNotificationHandler::OnClick(

Profile* profile,

const std::string& origin,

const std::string& notification_id,

- int action_index) {

+ int action_index,

+ base::NullableString16 reply) {

// Buttons not supported for non persistent notifications.

DCHECK_EQ(action_index, -1);

if (notifications_.find(notification_id) != notifications_.end()) {