Plumbing in notification replies: PlatformNotificationService -> SW

chrome/browser/notifications/non_persistent_notification_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NON_PERSISTENT_NOTIFICATION_HANDLER_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NON_PERSISTENT_NOTIFICATION_HANDLER_H_
 
 #include <unordered_map>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/strings/nullable_string16.h"

[Peter Beverloo, 2016/10/11 14:22:56]

nit: drop. Pretty much everywhere else too. Here's why:

non_persistent_notification_handler.h
persistent_notification_delegate.h
persistent_notification_handler.h
notification_event_dispatcher_impl.h

  We usually don't include headers for types required by an interface
  that's being implemented, since the interface's declaration
  (NotificationHandler, in this case) takes care of that.

non_persistent_notification_handler.cc
persistent_notification_handler.cc
platform_notification_service_impl.cc
notification_delegate.cc (for base::string16)

  The type is not used, so we don't need the full definition. For example,
  passing a const reference to another function is the same as passing
  a pointer - we don't need type information, only the address.

notification_handler.h
platform_notification_service_impl.h
notification_event_dispatcher.h
notification_delegate.h (for base::string16)

  We should forward declare the type instead. That means that files
  including one of these headers don't need to parse nullable_string16.h.

  namespace base {
  class NullableString16;
  }
 

[awdf, 2016/10/12 10:44:57]

Done.

 #include "chrome/browser/notifications/notification_handler.h"
 
 class NotificationDelegate;
 
 // NotificationHandler implementation for non persistent notifications.
 class NonPersistentNotificationHandler : public NotificationHandler {
  public:
   NonPersistentNotificationHandler();
   ~NonPersistentNotificationHandler() override;
 
   // NotificationHandler implementation
   void OnClose(Profile* profile,
                const std::string& origin,
                const std::string& notification_id,
                bool by_user) override;
 
   void OnClick(Profile* profile,
                const std::string& origin,
                const std::string& notification_id,
-               int action_index) override;
+               int action_index,
+               const base::NullableString16& reply) override;
 
   void OpenSettings(Profile* profile) override;
 
   void RegisterNotification(const std::string& notification_id,
                             NotificationDelegate* delegate) override;
 
  private:
   // map of delegate objects keyed by notification id.
   std::unordered_map<std::string, scoped_refptr<NotificationDelegate>>
       notifications_;
 
   DISALLOW_COPY_AND_ASSIGN(NonPersistentNotificationHandler);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NON_PERSISTENT_NOTIFICATION_HANDLER_H_