Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/notifications/non_persistent_notification_handler.cc

Issue 2392343002: Plumbing in notification replies: PlatformNotificationService -> SW (Closed)
Patch Set: Remove todo as it doesn't seem necessary after all Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/non_persistent_notification_handler.h" 5 #include "chrome/browser/notifications/non_persistent_notification_handler.h"
6 6
7 #include "base/strings/nullable_string16.h"
7 #include "chrome/browser/notifications/notification_delegate.h" 8 #include "chrome/browser/notifications/notification_delegate.h"
8 #include "chrome/browser/notifications/platform_notification_service_impl.h" 9 #include "chrome/browser/notifications/platform_notification_service_impl.h"
9 10
10 NonPersistentNotificationHandler::NonPersistentNotificationHandler() {} 11 NonPersistentNotificationHandler::NonPersistentNotificationHandler() {}
11 NonPersistentNotificationHandler::~NonPersistentNotificationHandler() {} 12 NonPersistentNotificationHandler::~NonPersistentNotificationHandler() {}
12 13
13 void NonPersistentNotificationHandler::OnClose( 14 void NonPersistentNotificationHandler::OnClose(
14 Profile* profile, 15 Profile* profile,
15 const std::string& origin, 16 const std::string& origin,
16 const std::string& notification_id, 17 const std::string& notification_id,
17 bool by_user) { 18 bool by_user) {
18 if (notifications_.find(notification_id) != notifications_.end()) { 19 if (notifications_.find(notification_id) != notifications_.end()) {
19 notifications_[notification_id]->Close(by_user); 20 notifications_[notification_id]->Close(by_user);
20 notifications_.erase(notification_id); 21 notifications_.erase(notification_id);
21 } 22 }
22 } 23 }
23 24
24 void NonPersistentNotificationHandler::OnClick( 25 void NonPersistentNotificationHandler::OnClick(
25 Profile* profile, 26 Profile* profile,
26 const std::string& origin, 27 const std::string& origin,
27 const std::string& notification_id, 28 const std::string& notification_id,
28 int action_index) { 29 int action_index,
30 const base::NullableString16& reply) {
29 // Buttons not supported for non persistent notifications. 31 // Buttons not supported for non persistent notifications.
30 DCHECK_EQ(action_index, -1); 32 DCHECK_EQ(action_index, -1);
31 if (notifications_.find(notification_id) != notifications_.end()) { 33 if (notifications_.find(notification_id) != notifications_.end()) {
32 notifications_[notification_id]->Click(); 34 notifications_[notification_id]->Click();
33 } 35 }
34 } 36 }
35 37
36 void NonPersistentNotificationHandler::OpenSettings(Profile* profile) { 38 void NonPersistentNotificationHandler::OpenSettings(Profile* profile) {
37 NotificationCommon::OpenNotificationSettings(profile); 39 NotificationCommon::OpenNotificationSettings(profile);
38 } 40 }
39 41
40 void NonPersistentNotificationHandler::RegisterNotification( 42 void NonPersistentNotificationHandler::RegisterNotification(
41 const std::string& notification_id, 43 const std::string& notification_id,
42 NotificationDelegate* delegate) { 44 NotificationDelegate* delegate) {
43 DCHECK_EQ(notifications_.count(notification_id), 0u); 45 DCHECK_EQ(notifications_.count(notification_id), 0u);
44 notifications_[notification_id] = 46 notifications_[notification_id] =
45 scoped_refptr<NotificationDelegate>(delegate); 47 scoped_refptr<NotificationDelegate>(delegate);
46 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698