Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2392333003: Incorporate 15 degree laser beam angle on pointer. (Closed)

Created:
4 years, 2 months ago by cjgrant
Modified:
4 years, 2 months ago
Reviewers:
mthiesse, bshe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Incorporate 15 degree laser beam angle on pointer. - Point the beam 15 degrees down from where the controller is pointing, for wrist comfort. - Fix the beam to point directly at the reticle. BUG=642058 Committed: https://crrev.com/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6 Cr-Commit-Position: refs/heads/master@{#423539}

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 10

Patch Set 3 : Address comments; improve CL description; improve naming; avoid a duplicate calculation. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 4 chunks +37 lines, -19 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
cjgrant
4 years, 2 months ago (2016-10-05 21:22:03 UTC) #2
mthiesse
https://codereview.chromium.org/2392333003/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2392333003/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode52 chrome/browser/android/vr_shell/vr_shell.cc:52: // Angle the beam down from the controller axis, ...
4 years, 2 months ago (2016-10-05 23:29:11 UTC) #3
cjgrant
https://codereview.chromium.org/2392333003/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2392333003/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode52 chrome/browser/android/vr_shell/vr_shell.cc:52: // Angle the beam down from the controller axis, ...
4 years, 2 months ago (2016-10-06 15:07:51 UTC) #5
bshe
lgtm
4 years, 2 months ago (2016-10-06 15:10:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392333003/40001
4 years, 2 months ago (2016-10-06 15:16:13 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 15:24:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:27:02 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07d8a34ed9c1f4292888b50a0f31797ccd0d39d6
Cr-Commit-Position: refs/heads/master@{#423539}

Powered by Google App Engine
This is Rietveld 408576698