third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp - Issue 2392313004: [wrapper-tracing] Add tracing to WebGLRenderingContextBase and friends

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

Issue 2392313004: [wrapper-tracing] Add tracing to WebGLRenderingContextBase and friends (Closed)

Patch Set: Add WebGL2RenderingContextBase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/webgl/WebGL2RenderingContext.h"	5 #include "modules/webgl/WebGL2RenderingContext.h"

6	6

7 #include "bindings/modules/v8/OffscreenCanvasRenderingContext2DOrWebGLRenderingC ontextOrWebGL2RenderingContext.h"	7 #include "bindings/modules/v8/OffscreenCanvasRenderingContext2DOrWebGLRenderingC ontextOrWebGL2RenderingContext.h"

8 #include "bindings/modules/v8/RenderingContext.h"	8 #include "bindings/modules/v8/RenderingContext.h"

9 #include "core/frame/LocalFrame.h"	9 #include "core/frame/LocalFrame.h"

10 #include "core/frame/Settings.h"	10 #include "core/frame/Settings.h"

(...skipping 146 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
157 visitor->traceWrappers(m_webglCompressedTextureASTC);	157 visitor->traceWrappers(m_webglCompressedTextureASTC);

158 visitor->traceWrappers(m_webglCompressedTextureATC);	158 visitor->traceWrappers(m_webglCompressedTextureATC);

159 visitor->traceWrappers(m_webglCompressedTextureES30);	159 visitor->traceWrappers(m_webglCompressedTextureES30);

160 visitor->traceWrappers(m_webglCompressedTextureETC1);	160 visitor->traceWrappers(m_webglCompressedTextureETC1);

161 visitor->traceWrappers(m_webglCompressedTexturePVRTC);	161 visitor->traceWrappers(m_webglCompressedTexturePVRTC);

162 visitor->traceWrappers(m_webglCompressedTextureS3TC);	162 visitor->traceWrappers(m_webglCompressedTextureS3TC);

163 visitor->traceWrappers(m_webglCompressedTextureS3TCsRGB);	163 visitor->traceWrappers(m_webglCompressedTextureS3TCsRGB);

164 visitor->traceWrappers(m_webglDebugRendererInfo);	164 visitor->traceWrappers(m_webglDebugRendererInfo);

165 visitor->traceWrappers(m_webglDebugShaders);	165 visitor->traceWrappers(m_webglDebugShaders);

166 visitor->traceWrappers(m_webglLoseContext);	166 visitor->traceWrappers(m_webglLoseContext);

	167 WebGL2RenderingContextBase::traceWrappers(visitor);
	Ken Russell (switch to Gerrit) 2016/10/06 19:05:14 The fact that this bug could happen is an indicati The fact that this bug could happen is an indication that we should strive to eliminate duplicated code between DEFINE_TRACE and DEFINE_TRACE_WRAPPERS. See below. Michael Lippautz 2016/10/06 19:58:13 Acknowledged. Show quoted text On 2016/10/06 19:05:14, Ken Russell wrote: > The fact that this bug could happen is an indication that we should strive to > eliminate duplicated code between DEFINE_TRACE and DEFINE_TRACE_WRAPPERS. See > below. Acknowledged.
167 }	168 }

168	169

169 } // namespace blink	170 } // namespace blink

OLD	NEW