Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2392313003: Fix a DCHECK failure in AppBannerManager when adding to homescreen from devtools. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 03587cb6bdb9e00845a49354ec40a55e20f053df..a46c9dd012bfe2d0e632f0e29f8051c6811b7250 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -126,6 +126,9 @@ void AppBannerManager::RequestAppBanner(const GURL& validated_url,
return;
}
+ if (validated_url_.is_empty())
+ validated_url_ = validated_url;
+
manager_->GetData(
ParamsToGetManifest(),
base::Bind(&AppBannerManager::OnDidGetManifest, GetWeakPtr()));
@@ -310,6 +313,7 @@ void AppBannerManager::Stop() {
was_canceled_by_page_ = false;
page_requested_prompt_ = false;
need_to_log_status_ = false;
+ validated_url_ = GURL();
referrer_.erase();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698