Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 2392303006: Add Feature tag to all ImportantSite tests (Closed)

Created:
4 years, 2 months ago by huapengl
Modified:
4 years, 2 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Feature tag to all ImportantSite tests This will allow users to exclusively run or ignore all ImportantSite tests at once. BUG=None Committed: https://crrev.com/443bd15a93307d095127bb8339f3f550ae9faa34 Cr-Commit-Position: refs/heads/master@{#423876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivityTest.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
huapengl
Hi, Can you please take a look? Thanks
4 years, 2 months ago (2016-10-06 19:04:55 UTC) #3
Finnur
LGTM BUG= should probably be BUG=None, unless you have a bug on file that is ...
4 years, 2 months ago (2016-10-07 10:18:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392303006/1
4 years, 2 months ago (2016-10-07 15:56:54 UTC) #7
huapengl
On 2016/10/07 10:18:07, Finnur wrote: > LGTM > > BUG= should probably be BUG=None, unless ...
4 years, 2 months ago (2016-10-07 16:20:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 16:26:50 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:28:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443bd15a93307d095127bb8339f3f550ae9faa34
Cr-Commit-Position: refs/heads/master@{#423876}

Powered by Google App Engine
This is Rietveld 408576698