Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2392303004: [parser] Remove obsolete ParseInfo::is_global flag. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
titzer, marja, jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Remove obsolete ParseInfo::is_global flag. R=marja@chromium.org Committed: https://crrev.com/18f287572e3a3d45ed4562f13e61496ba415dcb8 Cr-Commit-Position: refs/heads/master@{#40070}

Patch Set 1 #

Patch Set 2 : Also renumber flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -41 lines) Patch
M src/background-parsing-task.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 6 chunks +1 line, -12 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/parsing/parse-info.h View 1 2 chunks +8 lines, -10 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 6 chunks +1 line, -10 lines 0 comments Download
M test/fuzzer/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/parser-shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-06 13:38:54 UTC) #3
Michael Starzinger
+Jakob: Need debugger owner stamp.
4 years, 2 months ago (2016-10-06 13:39:49 UTC) #5
jgruber
lgtm debug/
4 years, 2 months ago (2016-10-06 13:43:20 UTC) #6
marja
lgtm - nice!
4 years, 2 months ago (2016-10-07 07:26:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392303004/20001
4 years, 2 months ago (2016-10-07 08:10:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25891)
4 years, 2 months ago (2016-10-07 08:14:49 UTC) #16
Michael Starzinger
+Ben: Need WASM owner stamp.
4 years, 2 months ago (2016-10-07 08:19:06 UTC) #18
titzer
On 2016/10/07 08:19:06, Michael Starzinger wrote: > +Ben: Need WASM owner stamp. lgtm
4 years, 2 months ago (2016-10-07 08:22:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392303004/20001
4 years, 2 months ago (2016-10-07 08:27:28 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 08:29:47 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 08:30:09 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18f287572e3a3d45ed4562f13e61496ba415dcb8
Cr-Commit-Position: refs/heads/master@{#40070}

Powered by Google App Engine
This is Rietveld 408576698