Bug fix: Append a language to the list after blocking it for Translate on Chrome OS

chrome/browser/translate/translate_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 
 #include <algorithm>
 
 #include "base/i18n/string_compare.h"
 #include "base/metrics/histogram.h"
@@ skipping 193 matching lines @@
 void TranslateInfoBarDelegate::AlwaysTranslatePageLanguage() {
   const std::string& original_lang = original_language_code();
   const std::string& target_lang = target_language_code();
   DCHECK(!prefs_.IsLanguagePairWhitelisted(original_lang, target_lang));
   prefs_.WhitelistLanguagePair(original_lang, target_lang);
   Translate();
 }
 
 void TranslateInfoBarDelegate::NeverTranslatePageLanguage() {
   std::string original_lang = original_language_code();
-  DCHECK(!prefs_.IsBlockedLanguage(original_lang));
+
+  // Don't use DCHECK(...) to check if the language is listed in the blocked

[Evan Stade, 2013/09/12 22:53:41]

this comment seems pretty long to explain why a thing is NOT here. I would
remove it.

[hajimehoshi, 2013/09/13 01:39:19]

Ok, I'll write the explanation at the description of this CL instead of here.

+  // language list here because the language might already be listed. For
+  // example:
+  // 1. After the user add the language, he/she removes the language from
+  //    chrome://settings/languages. In this case, Translate infobar will
+  //    appear.
+  // 2. While the Translate infobar is shown, the user can change if Translate
+  //    should be offered in the language. In this case, the user can push
+  //    "Never Translate (language)" button while the language is already
+  //    blocked.
   prefs_.BlockLanguage(original_lang);
   RemoveSelf();
 }
 
 string16 TranslateInfoBarDelegate::GetMessageInfoBarText() {
   if (infobar_type_ == TRANSLATING) {
     return l10n_util::GetStringFUTF16(IDS_TRANSLATE_INFOBAR_TRANSLATING_TO,
                                       language_name_at(target_language_index_));
   }
 
@@ skipping 200 matching lines @@
 
 TranslateInfoBarDelegate*
     TranslateInfoBarDelegate::AsTranslateInfoBarDelegate() {
   return this;
 }
 
 std::string TranslateInfoBarDelegate::GetPageHost() {
   NavigationEntry* entry = web_contents()->GetController().GetActiveEntry();
   return entry ? entry->GetURL().HostNoBrackets() : std::string();
 }