Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2392293002:
Disable thread checking for LGE email app (Closed)
|
Created:
4 years, 2 months ago by Changwan Ryu Modified:
4 years, 2 months ago CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable thread checking for LGE email app
LGE's email app runs UI thread methods from InputConnection. As this is
becoming impossible, we need to work around LGE email case. Hopefully this
is the last webview app that does it.
BUG=651706
Committed: https://crrev.com/56ededfef7d8cb57ea37b30c0ba5e25de2b0019b
Cr-Commit-Position: refs/heads/master@{#423878}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add version code placeholder #Patch Set 3 : use real version code and limit target sdk to n #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by changwan@chromium.org to run a CQ dry run
changwan@chromium.org changed reviewers: + aelias@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2392293002/diff/1/android_webview/glue/java/s... File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/2392293002/diff/1/android_webview/glue/java/s... android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:529: // TODO(changwan): need to do version check once LGE notifies us. Can you fill in the code with placeholder version number that I posted on the bug? (also on the other patch)
lgtm. On second thought, I'll let you decide when/how you want to deal with version code. I know it can be useful to push a beta to coordinate with LG, so we can add version check in a later patch, the main thing is not to go stable with it.
aelias@chromium.org changed reviewers: + torne@chromium.org
Adding torne@ for android_webview/ OWNERS
The CQ bit was checked by changwan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2392293002/diff/1/android_webview/glue/java/s... File android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java (right): https://codereview.chromium.org/2392293002/diff/1/android_webview/glue/java/s... android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:529: // TODO(changwan): need to do version check once LGE notifies us. On 2016/10/05 23:01:53, aelias wrote: > Can you fill in the code with placeholder version number that I posted on the > bug? (also on the other patch) Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by changwan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org, torne@chromium.org Link to the patchset: https://codereview.chromium.org/2392293002/#ps40001 (title: "use real version code and limit target sdk to n")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disable thread checking for LGE email app LGE's email app runs UI thread methods from InputConnection. As this is becoming impossible, we need to work around LGE email case. Hopefully this is the last webview app that does it. BUG=651706 ========== to ========== Disable thread checking for LGE email app LGE's email app runs UI thread methods from InputConnection. As this is becoming impossible, we need to work around LGE email case. Hopefully this is the last webview app that does it. BUG=651706 Committed: https://crrev.com/56ededfef7d8cb57ea37b30c0ba5e25de2b0019b Cr-Commit-Position: refs/heads/master@{#423878} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/56ededfef7d8cb57ea37b30c0ba5e25de2b0019b Cr-Commit-Position: refs/heads/master@{#423878} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
