Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2392283004: [MD settings] right arrow for manage other people setting row (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] right arrow for manage other people setting row Alan requested that the settings row for Manage other people have the right arrow icon. BUG=652803 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0621a8672ffe73a70dae79c26f95e84db4c5c08c Cr-Commit-Position: refs/heads/master@{#423608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 2 months ago (2016-10-06 00:36:31 UTC) #4
dpapad
lgtm
4 years, 2 months ago (2016-10-06 01:16:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392283004/1
4 years, 2 months ago (2016-10-06 18:44:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 18:51:46 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:55:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0621a8672ffe73a70dae79c26f95e84db4c5c08c
Cr-Commit-Position: refs/heads/master@{#423608}

Powered by Google App Engine
This is Rietveld 408576698