Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2392263002: Enable MidiManagerWinrt by default on Windows 10 (Closed)

Created:
4 years, 2 months ago by Shao-Chuan Lee
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MidiManagerWinrt by default on Windows 10 Added runtime flag to disable the new backend. BUG=645403 Committed: https://crrev.com/e041dc3faab67129c30b9c29d7e7ae74997ee0fd Cr-Commit-Position: refs/heads/master@{#423116}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M media/midi/midi_manager_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/midi/midi_switches.h View 1 chunk +2 lines, -10 lines 0 comments Download
M media/midi/midi_switches.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Shao-Chuan Lee
isherman@: PTAL at histograms.xml, thanks.
4 years, 2 months ago (2016-10-05 05:22:08 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 2 months ago (2016-10-05 05:49:19 UTC) #3
Takashi Toyoshima
midi lgtm
4 years, 2 months ago (2016-10-05 06:10:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392263002/1
4 years, 2 months ago (2016-10-05 06:11:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/80692) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-05 06:12:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392263002/20001
4 years, 2 months ago (2016-10-05 06:24:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 08:39:52 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 08:41:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e041dc3faab67129c30b9c29d7e7ae74997ee0fd
Cr-Commit-Position: refs/heads/master@{#423116}

Powered by Google App Engine
This is Rietveld 408576698