Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3012)

Unified Diff: chrome/browser/ui/login/login_handler.cc

Issue 2392243002: Simplify origin logic in login_handler (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/login/login_handler.cc
diff --git a/chrome/browser/ui/login/login_handler.cc b/chrome/browser/ui/login/login_handler.cc
index 2a3ecdf5b5b5c5d098d25dbaa168064f16b19e83..89318392154c3634dd45e691cbf8cca35844391f 100644
--- a/chrome/browser/ui/login/login_handler.cc
+++ b/chrome/browser/ui/login/login_handler.cc
@@ -475,14 +475,9 @@ PasswordForm LoginHandler::MakeInputForPasswordManager(
} else {
dialog_form.scheme = PasswordForm::SCHEME_OTHER;
}
- if (auth_info.is_proxy) {
- dialog_form.origin = auth_info.challenger.GetURL();
- } else if (!auth_info.challenger.IsSameOriginWith(url::Origin(request_url))) {
- dialog_form.origin = GURL();
- NOTREACHED(); // crbug.com/32718
- } else {
- dialog_form.origin = auth_info.challenger.GetURL();
- }
+ dialog_form.origin = auth_info.challenger.GetURL();
+ DCHECK(auth_info.is_proxy ||
+ auth_info.challenger.IsSameOriginWith(url::Origin(request_url)));
dialog_form.signon_realm = GetSignonRealm(dialog_form.origin, auth_info);
return dialog_form;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698