Handlify and convert Script accesssors to new API-style accessors.

Handlify and convert Script accesssors to new API-style accessors.

BUG=
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20799

[ulan, 2014-04-15 14:36:23]

PTAL

[Yang, 2014-04-15 14:50:35]

lgtm.

https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo<void>& info) {
You could have one single setter that's unreachable, and call it something like
IllegalCallback.

[ulan, 2014-04-15 14:55:18]

https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo<void>& info) {
On 2014/04/15 14:50:35, Yang wrote:
> You could have one single setter that's unreachable, and call it something
like
> IllegalCallback.

I use one macro to access both the getter and the setter from the field name, so
I need to define the setter. I can change that later on to use a different macro
for read-only fields.

[Yang, 2014-04-15 14:59:59]

On 2014/04/15 14:55:18, ulan wrote:
> https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
> File src/accessors.cc (right):
> 
> https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
> src/accessors.cc:389: const v8::PropertyCallbackInfo<void>& info) {
> On 2014/04/15 14:50:35, Yang wrote:
> > You could have one single setter that's unreachable, and call it something
> like
> > IllegalCallback.
> 
> I use one macro to access both the getter and the setter from the field name,
so
> I need to define the setter. I can change that later on to use a different
macro
> for read-only fields.
Lgtm

[ulan, 2014-04-16 11:57:31]

Committed patchset #1 manually as r20799 (presubmit successful).