Issue 23922004: Set USE(HARFBUZZ) in config.h instead of a gyp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23922004: Set USE(HARFBUZZ) in config.h instead of a gyp file (Closed)

Created:
7 years, 3 months ago by lgombos

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Set USE(HARFBUZZ) in config.h instead of a gyp file. USE(HARFBUZZ) does not need to be exposed to the gyp build system. BUG=286578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157412

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	Source/config.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/core/features.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 6 (0 generated)

lgombos

This is to make USE() macros more consistent and minimize the configurations/variations exposed to build ...

7 years, 3 months ago (2013-09-07 03:29:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23922004/1

7 years, 3 months ago (2013-09-07 20:46:00 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 3 months ago (2013-09-07 21:33:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23922004/1

7 years, 3 months ago (2013-09-07 22:03:56 UTC) #5

Message was sent while issue was closed.

Change committed as 157412