Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23922003: Revert 221651 "Switch to doing user-resizing via system for pane..." (Closed)

Created:
7 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 3 months ago
Reviewers:
jianli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221651 "Switch to doing user-resizing via system for pane..." > Switch to doing user-resizing via system for panels on Mac > > We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems. > > Also removed EnableResizeByMouse which is not really used in our code. > > BUG=282652, 282657 > TEST=manual test by user-resizing panels > > Review URL: https://chromiumcodereview.appspot.com/23918002 Reverted since I suspect that it caused http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/41303/steps/interactive_ui_tests/logs/FocusNextPanelOnPanelClose TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -195 lines) Patch
M trunk/src/chrome/browser/ui/cocoa/panels/panel_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/panels/panel_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h View 1 chunk +3 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/panels/panel_utils_cocoa.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 4 chunks +3 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 9 chunks +260 lines, -164 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/panels/panel_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/panels/panel_gtk.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/detached_panel_collection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/docked_panel_collection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/native_panel.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/panel.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/panel.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/panels/stacked_panel_collection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/panels/panel_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/panels/panel_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
henrika (OOO until Aug 14)
7 years, 3 months ago (2013-09-06 10:59:21 UTC) #1
henrika (OOO until Aug 14)
7 years, 3 months ago (2013-09-06 10:59:39 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r221674.

Powered by Google App Engine
This is Rietveld 408576698