Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2392183002: Add check to identify the cause of the crash. (Closed)

Created:
4 years, 2 months ago by oshima
Modified:
4 years, 2 months ago
Reviewers:
afakhry
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add check to investigate the crash. I run the clusterfuzz test locally but couldn't reproduce this crash. The crash can happen if the bubble gets closed after activation, so adding CHECK to investigate how that's happening. BUG=651242 Committed: https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f Cr-Commit-Position: refs/heads/master@{#423547}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add check to identify the cause of the crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ash/common/system/tray/system_tray.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
oshima
4 years, 2 months ago (2016-10-05 19:40:03 UTC) #8
afakhry
lgtm https://codereview.chromium.org/2392183002/diff/1/ash/common/system/tray/system_tray.h File ash/common/system/tray/system_tray.h (right): https://codereview.chromium.org/2392183002/diff/1/ash/common/system/tray/system_tray.h#newcode286 ash/common/system/tray/system_tray.h:286: // TODO(oshima): Remove this whwn crbug.com/651242 is fixed. ...
4 years, 2 months ago (2016-10-05 23:32:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392183002/20001
4 years, 2 months ago (2016-10-06 15:21:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 15:49:51 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f Cr-Commit-Position: refs/heads/master@{#423547}
4 years, 2 months ago (2016-10-06 15:51:24 UTC) #16
oshima
4 years, 2 months ago (2016-10-06 20:43:53 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2392183002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.h (right):

https://codereview.chromium.org/2392183002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.h:286: // TODO(oshima): Remove this whwn
crbug.com/651242 is fixed.
On 2016/10/05 23:32:02, afakhry wrote:
> Nit: whwn --> when

Done.

Powered by Google App Engine
This is Rietveld 408576698