Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2392143004: Use calendar.timegm instead of time.mktime in recipes (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
jcgregorio, borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use calendar.timegm instead of time.mktime in recipes Timezones are hard. BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392143004 Committed: https://skia.googlesource.com/skia/+/2f036965f0ab7abf79866fb5a35f57d959b81022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M infra/bots/recipes/swarm_perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus6-GPU-Adreno420-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/upload_dm_results.py View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/upload_dm_results.expected/failed_once.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/upload_dm_results.expected/normal_bot.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/upload_dm_results.expected/recipe_with_gerrit_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/upload_dm_results.expected/trybot.json View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
borenet
4 years, 2 months ago (2016-10-05 18:07:42 UTC) #3
jcgregorio
lgtm
4 years, 2 months ago (2016-10-05 18:24:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392143004/1
4 years, 2 months ago (2016-10-05 18:42:24 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:43:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f036965f0ab7abf79866fb5a35f57d959b81022

Powered by Google App Engine
This is Rietveld 408576698