Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2392133002: Fix BazelFileUriResolver tests (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov, jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 1 1 chunk +5 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 3 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This should cause the tests to pass on the windows bot and has the extra ...
4 years, 2 months ago (2016-10-04 20:53:38 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-04 20:55:47 UTC) #3
jwren
On 2016/10/04 20:55:47, scheglov wrote: > LGTM LGTM
4 years, 2 months ago (2016-10-04 21:14:10 UTC) #4
Brian Wilkerson
4 years, 2 months ago (2016-10-04 21:17:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a52e53a3b21858c740be51722c5e75725074b8ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698