Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2392123002: [Devtools] Use requestAnimationFrame instead of timer in network (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Use requestAnimationFrame instead of timer in network This patch is to increase perceived performance of network panel by using requestAnimationFrame instead of setTimeout for scheduled refreshes. R=lushnikov BUG=None Committed: https://crrev.com/0eac373e82ab7916c507c4f4cad05cd0649e8758 Cr-Commit-Position: refs/heads/master@{#423039}

Patch Set 1 #

Total comments: 1

Patch Set 2 : [Devtools] Use requestAnimationFrame instead of timer in network #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
allada
PTL
4 years, 2 months ago (2016-10-04 20:49:08 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/2392123002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2392123002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode463 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:463: if (this.isShowing() && !this._refreshRequestID) nit: _refreshRequestId
4 years, 2 months ago (2016-10-04 21:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392123002/20001
4 years, 2 months ago (2016-10-04 23:08:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 01:27:51 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 01:31:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0eac373e82ab7916c507c4f4cad05cd0649e8758
Cr-Commit-Position: refs/heads/master@{#423039}

Powered by Google App Engine
This is Rietveld 408576698