Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2392113004: Removing DUMP_VIDEO and TEST_REAL_CAPTURE_DEVICE from VideoCaptureHostTest (Closed)

Created:
4 years, 2 months ago by preeti.nayak
Modified:
4 years ago
Reviewers:
mcasas, pals
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing DUMP_VIDEO and TEST_REAL_CAPTURE_DEVICE from VideoCaptureHostTest BUG=651937

Patch Set 1 #

Patch Set 2 : Removing DUMP_VIDEO and TEST_REAL_CAPTURE_DEVICE from VideoCaptureHostTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 4 chunks +2 lines, -38 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
preeti.nayak
This is my first patch. Please review it.
4 years, 2 months ago (2016-10-05 05:54:45 UTC) #2
mcasas
On 2016/10/05 05:54:45, preeti.nayak wrote: > This is my first patch. Please review it. Not ...
4 years, 2 months ago (2016-10-05 14:38:52 UTC) #3
preeti.nayak
On 2016/10/05 14:38:52, mcasas wrote: > On 2016/10/05 05:54:45, preeti.nayak wrote: > > This is ...
4 years, 2 months ago (2016-10-06 06:11:25 UTC) #6
jam
4 years, 2 months ago (2016-10-10 14:58:45 UTC) #8 
On 2016/10/06 06:11:25, preeti.nayak wrote:
> On 2016/10/05 14:38:52, mcasas wrote:
> > On 2016/10/05 05:54:45, preeti.nayak wrote:
> > > This is my first patch. Please review it.
> > 
> > Not enough: you have to remove the usage of those flags as well.
> 
> Ok. I'll remove them and upload another patch soon. Thanks!

please pick a specific reviewer (i.e. from
content/browser/renderer_host/media/owners), i'm removing myself.

Powered by Google App Engine
This is Rietveld 408576698