Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2392103002: Avoid crashing on CPDF_ToUnicodeMap::Load by using ValueOrDefault() (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid crashing on CPDF_ToUnicodeMap::Load by using ValueOrDefault() - Added private method to avoid duplicated code. - If the unicode calculation overflows, 0 is used instead of crashing. Committed: https://pdfium.googlesource.com/pdfium/+/1c4b767e822a7537f2c6c19b42dddce840e033ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M core/fpdfapi/font/font_int.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/font/fpdf_font.cpp View 4 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 2 months ago (2016-10-04 19:51:35 UTC) #5
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-04 19:59:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392103002/1
4 years, 2 months ago (2016-10-04 20:00:24 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 20:00:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1c4b767e822a7537f2c6c19b42dddce840e0...

Powered by Google App Engine
This is Rietveld 408576698