Add --test to gen_tasks.go, add presubmit check

Add --test to gen_tasks.go, add presubmit check

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002

Committed: https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f

[borenet2, 2016-10-04 18:42:20]

Description was changed from

==========
Add --test to gen_tasks.go, add presubmit check

BUG=skia:
==========

to

==========
Add --test to gen_tasks.go, add presubmit check

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002
==========

[borenet, 2016-10-04 18:59:47]

borenet@google.com changed reviewers:
+ benjaminwagner@google.com, borenet@google.com, rmistry@google.com

[borenet, 2016-10-04 18:59:48]

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py#newcode257
PRESUBMIT.py:257: results.extend(_GenTasksTest(input_api, output_api))
This is really unfortunate. We need to be able to test these on the CQ.

[dogben, 2016-10-04 19:16:23]

lgtm

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py#newcode257
PRESUBMIT.py:257: results.extend(_GenTasksTest(input_api, output_api))
On 2016/10/04 at 18:59:47, borenet wrote:
> This is really unfortunate. We need to be able to test these on the CQ.

Is there a reason skia_presubmit-Trybot doesn't run on swarming (or
swarmbucket)?

[borenet, 2016-10-04 19:26:55]

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py#newcode257
PRESUBMIT.py:257: results.extend(_GenTasksTest(input_api, output_api))
On 2016/10/04 19:16:23, dogben wrote:
> On 2016/10/04 at 18:59:47, borenet wrote:
> > This is really unfortunate. We need to be able to test these on the CQ.
> 
> Is there a reason skia_presubmit-Trybot doesn't run on swarming (or
> swarmbucket)?

That bot was brought up by chrome-infra after they turned off presubmit checks
on the CQ itself. It's running a non-skia recipe
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...),
and I had previously dismissed it as not under our control. I guess all that
matters is that we run the presubmit on a trybot somewhere, so we could possibly
create our own presubmit recipe, add a bot which runs that in Swarming, and then
turn the current presubmit bot off.

[borenet, 2016-10-04 19:28:14]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-10-04 19:28:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-10-04 19:32:22]

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2392083002/diff/20001/PRESUBMIT.py#newcode257
PRESUBMIT.py:257: results.extend(_GenTasksTest(input_api, output_api))
On 2016/10/04 19:26:55, borenet wrote:
> On 2016/10/04 19:16:23, dogben wrote:
> > On 2016/10/04 at 18:59:47, borenet wrote:
> > > This is really unfortunate. We need to be able to test these on the CQ.
> > 
> > Is there a reason skia_presubmit-Trybot doesn't run on swarming (or
> > swarmbucket)?
> 
> That bot was brought up by chrome-infra after they turned off presubmit checks
> on the CQ itself. It's running a non-skia recipe
>
(https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...),
> and I had previously dismissed it as not under our control. I guess all that
> matters is that we run the presubmit on a trybot somewhere, so we could
possibly
> create our own presubmit recipe, add a bot which runs that in Swarming, and
then
> turn the current presubmit bot off.

Filed https://bugs.chromium.org/p/skia/issues/detail?id=5823

[commit-bot: I haz the power, 2016-10-04 19:45:42]

Description was changed from

==========
Add --test to gen_tasks.go, add presubmit check

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002
==========

to

==========
Add --test to gen_tasks.go, add presubmit check

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002

Committed:
https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f
==========

[commit-bot: I haz the power, 2016-10-04 19:45:43]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f

[mtklein_C, 2016-10-04 21:11:07]

On 2016/10/04 at 19:45:43, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f

Hey, how do I fix this?

Running presubmit upload checks ...
infra/bots/gen_tasks.go:23:2: cannot find package "github.com/skia-dev/glog" in
any of:
	/usr/lib/go/src/github.com/skia-dev/glog (from $GOROOT)
	/home/mtklein/src/github.com/skia-dev/glog (from $GOPATH)
infra/bots/gen_tasks.go:24:2: cannot find package "go.skia.org/infra/go/common"
in any of:
	/usr/lib/go/src/go.skia.org/infra/go/common (from $GOROOT)
	/home/mtklein/src/go.skia.org/infra/go/common (from $GOPATH)
infra/bots/gen_tasks.go:25:2: cannot find package "go.skia.org/infra/go/util" in
any of:
	/usr/lib/go/src/go.skia.org/infra/go/util (from $GOROOT)
	/home/mtklein/src/go.skia.org/infra/go/util (from $GOPATH)
infra/bots/gen_tasks.go:26:2: cannot find package
"go.skia.org/infra/task_scheduler/go/specs" in any of:
	/usr/lib/go/src/go.skia.org/infra/task_scheduler/go/specs (from $GOROOT)
	/home/mtklein/src/go.skia.org/infra/task_scheduler/go/specs (from $GOPATH)

** Presubmit ERRORS **
`go run infra/bots/gen_tasks.go --test` failed:

[borenet, 2016-10-04 21:12:06]

On 2016/10/04 21:11:07, mtklein_C wrote:
> On 2016/10/04 at 19:45:43, commit-bot wrote:
> > Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f
> 
> Hey, how do I fix this?
> 
> Running presubmit upload checks ...
> infra/bots/gen_tasks.go:23:2: cannot find package "github.com/skia-dev/glog"
in
> any of:
> 	/usr/lib/go/src/github.com/skia-dev/glog (from $GOROOT)
> 	/home/mtklein/src/github.com/skia-dev/glog (from $GOPATH)
> infra/bots/gen_tasks.go:24:2: cannot find package
"go.skia.org/infra/go/common"
> in any of:
> 	/usr/lib/go/src/go.skia.org/infra/go/common (from $GOROOT)
> 	/home/mtklein/src/go.skia.org/infra/go/common (from $GOPATH)
> infra/bots/gen_tasks.go:25:2: cannot find package "go.skia.org/infra/go/util"
in
> any of:
> 	/usr/lib/go/src/go.skia.org/infra/go/util (from $GOROOT)
> 	/home/mtklein/src/go.skia.org/infra/go/util (from $GOPATH)
> infra/bots/gen_tasks.go:26:2: cannot find package
> "go.skia.org/infra/task_scheduler/go/specs" in any of:
> 	/usr/lib/go/src/go.skia.org/infra/task_scheduler/go/specs (from $GOROOT)
> 	/home/mtklein/src/go.skia.org/infra/task_scheduler/go/specs (from $GOPATH)
> 
> ** Presubmit ERRORS **
> `go run infra/bots/gen_tasks.go --test` failed:

go get github.com/skia-dev/glog

Or more generally:

go get -u go.skia.org/infra

[mtklein_C, 2016-10-04 21:31:14]

On 2016/10/04 at 21:12:06, borenet wrote:
> On 2016/10/04 21:11:07, mtklein_C wrote:
> > On 2016/10/04 at 19:45:43, commit-bot wrote:
> > > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f
> > 
> > Hey, how do I fix this?
> > 
> > Running presubmit upload checks ...
> > infra/bots/gen_tasks.go:23:2: cannot find package "github.com/skia-dev/glog"
in
> > any of:
> > 	/usr/lib/go/src/github.com/skia-dev/glog (from $GOROOT)
> > 	/home/mtklein/src/github.com/skia-dev/glog (from $GOPATH)
> > infra/bots/gen_tasks.go:24:2: cannot find package
"go.skia.org/infra/go/common"
> > in any of:
> > 	/usr/lib/go/src/go.skia.org/infra/go/common (from $GOROOT)
> > 	/home/mtklein/src/go.skia.org/infra/go/common (from $GOPATH)
> > infra/bots/gen_tasks.go:25:2: cannot find package
"go.skia.org/infra/go/util" in
> > any of:
> > 	/usr/lib/go/src/go.skia.org/infra/go/util (from $GOROOT)
> > 	/home/mtklein/src/go.skia.org/infra/go/util (from $GOPATH)
> > infra/bots/gen_tasks.go:26:2: cannot find package
> > "go.skia.org/infra/task_scheduler/go/specs" in any of:
> > 	/usr/lib/go/src/go.skia.org/infra/task_scheduler/go/specs (from $GOROOT)
> > 	/home/mtklein/src/go.skia.org/infra/task_scheduler/go/specs (from $GOPATH)
> > 
> > ** Presubmit ERRORS **
> > `go run infra/bots/gen_tasks.go --test` failed:
> 
> go get github.com/skia-dev/glog
> 
> Or more generally:
> 
> go get -u go.skia.org/infra

Now I get,

mtklein@linux ~/skia (extar)> git cl presubmit -u
Running presubmit upload checks ...
../src/go.skia.org/infra/go/isolate/isolate.go:20:2: cannot find package
"cloud.google.com/go/storage" in any of:
	/usr/lib/go/src/cloud.google.com/go/storage (from $GOROOT)
	/home/mtklein/src/cloud.google.com/go/storage (from $GOPATH)
../src/go.skia.org/infra/task_scheduler/go/db/task.go:16:2: cannot find package
"github.com/luci/luci-go/common/api/swarming/swarming/v1" in any of:
	/usr/lib/go/src/github.com/luci/luci-go/common/api/swarming/swarming/v1 (from
$GOROOT)
	/home/mtklein/src/github.com/luci/luci-go/common/api/swarming/swarming/v1 (from
$GOPATH)
../src/go.skia.org/infra/task_scheduler/go/db/memory.go:11:2: cannot find
package "github.com/satori/go.uuid" in any of:
	/usr/lib/go/src/github.com/satori/go.uuid (from $GOROOT)
	/home/mtklein/src/github.com/satori/go.uuid (from $GOPATH)
../src/go.skia.org/infra/go/gs/testing.go:16:2: cannot find package
"google.golang.org/api/option" in any of:
	/usr/lib/go/src/google.golang.org/api/option (from $GOROOT)
	/home/mtklein/src/google.golang.org/api/option (from $GOPATH)

** Presubmit ERRORS **
`go run infra/bots/gen_tasks.go --test` failed:


Presubmit checks took 3.6s to calculate.

[borenet, 2016-10-04 21:47:38]

On 2016/10/04 21:31:14, mtklein_C wrote:
> On 2016/10/04 at 21:12:06, borenet wrote:
> > On 2016/10/04 21:11:07, mtklein_C wrote:
> > > On 2016/10/04 at 19:45:43, commit-bot wrote:
> > > > Committed patchset #2 (id:20001) as
> > >
> https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f
> > > 
> > > Hey, how do I fix this?
> > > 
> > > Running presubmit upload checks ...
> > > infra/bots/gen_tasks.go:23:2: cannot find package
"github.com/skia-dev/glog"
> in
> > > any of:
> > > 	/usr/lib/go/src/github.com/skia-dev/glog (from $GOROOT)
> > > 	/home/mtklein/src/github.com/skia-dev/glog (from $GOPATH)
> > > infra/bots/gen_tasks.go:24:2: cannot find package
> "go.skia.org/infra/go/common"
> > > in any of:
> > > 	/usr/lib/go/src/go.skia.org/infra/go/common (from $GOROOT)
> > > 	/home/mtklein/src/go.skia.org/infra/go/common (from $GOPATH)
> > > infra/bots/gen_tasks.go:25:2: cannot find package
> "go.skia.org/infra/go/util" in
> > > any of:
> > > 	/usr/lib/go/src/go.skia.org/infra/go/util (from $GOROOT)
> > > 	/home/mtklein/src/go.skia.org/infra/go/util (from $GOPATH)
> > > infra/bots/gen_tasks.go:26:2: cannot find package
> > > "go.skia.org/infra/task_scheduler/go/specs" in any of:
> > > 	/usr/lib/go/src/go.skia.org/infra/task_scheduler/go/specs (from $GOROOT)
> > > 	/home/mtklein/src/go.skia.org/infra/task_scheduler/go/specs (from
$GOPATH)
> > > 
> > > ** Presubmit ERRORS **
> > > `go run infra/bots/gen_tasks.go --test` failed:
> > 
> > go get github.com/skia-dev/glog
> > 
> > Or more generally:
> > 
> > go get -u go.skia.org/infra
> 
> Now I get,
> 
> mtklein@linux ~/skia (extar)> git cl presubmit -u
> Running presubmit upload checks ...
> ../src/go.skia.org/infra/go/isolate/isolate.go:20:2: cannot find package
> "cloud.google.com/go/storage" in any of:
> 	/usr/lib/go/src/cloud.google.com/go/storage (from $GOROOT)
> 	/home/mtklein/src/cloud.google.com/go/storage (from $GOPATH)
> ../src/go.skia.org/infra/task_scheduler/go/db/task.go:16:2: cannot find
package
> "github.com/luci/luci-go/common/api/swarming/swarming/v1" in any of:
> 	/usr/lib/go/src/github.com/luci/luci-go/common/api/swarming/swarming/v1 (from
> $GOROOT)
> 	/home/mtklein/src/github.com/luci/luci-go/common/api/swarming/swarming/v1
(from
> $GOPATH)
> ../src/go.skia.org/infra/task_scheduler/go/db/memory.go:11:2: cannot find
> package "github.com/satori/go.uuid" in any of:
> 	/usr/lib/go/src/github.com/satori/go.uuid (from $GOROOT)
> 	/home/mtklein/src/github.com/satori/go.uuid (from $GOPATH)
> ../src/go.skia.org/infra/go/gs/testing.go:16:2: cannot find package
> "google.golang.org/api/option" in any of:
> 	/usr/lib/go/src/google.golang.org/api/option (from $GOROOT)
> 	/home/mtklein/src/google.golang.org/api/option (from $GOPATH)
> 
> ** Presubmit ERRORS **
> `go run infra/bots/gen_tasks.go --test` failed:
> 
> 
> Presubmit checks took 3.6s to calculate.

That's after a "go get -u go.skia.org/infra/..." ?

[mtklein, 2016-10-04 22:42:57]

On 2016/10/04 21:47:38, borenet wrote:
> On 2016/10/04 21:31:14, mtklein_C wrote:
> > On 2016/10/04 at 21:12:06, borenet wrote:
> > > On 2016/10/04 21:11:07, mtklein_C wrote:
> > > > On 2016/10/04 at 19:45:43, commit-bot wrote:
> > > > > Committed patchset #2 (id:20001) as
> > > >
> >
https://skia.googlesource.com/skia/+/60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f
> > > > 
> > > > Hey, how do I fix this?
> > > > 
> > > > Running presubmit upload checks ...
> > > > infra/bots/gen_tasks.go:23:2: cannot find package
> "github.com/skia-dev/glog"
> > in
> > > > any of:
> > > > 	/usr/lib/go/src/github.com/skia-dev/glog (from $GOROOT)
> > > > 	/home/mtklein/src/github.com/skia-dev/glog (from $GOPATH)
> > > > infra/bots/gen_tasks.go:24:2: cannot find package
> > "go.skia.org/infra/go/common"
> > > > in any of:
> > > > 	/usr/lib/go/src/go.skia.org/infra/go/common (from $GOROOT)
> > > > 	/home/mtklein/src/go.skia.org/infra/go/common (from $GOPATH)
> > > > infra/bots/gen_tasks.go:25:2: cannot find package
> > "go.skia.org/infra/go/util" in
> > > > any of:
> > > > 	/usr/lib/go/src/go.skia.org/infra/go/util (from $GOROOT)
> > > > 	/home/mtklein/src/go.skia.org/infra/go/util (from $GOPATH)
> > > > infra/bots/gen_tasks.go:26:2: cannot find package
> > > > "go.skia.org/infra/task_scheduler/go/specs" in any of:
> > > > 	/usr/lib/go/src/go.skia.org/infra/task_scheduler/go/specs (from
$GOROOT)
> > > > 	/home/mtklein/src/go.skia.org/infra/task_scheduler/go/specs (from
> $GOPATH)
> > > > 
> > > > ** Presubmit ERRORS **
> > > > `go run infra/bots/gen_tasks.go --test` failed:
> > > 
> > > go get github.com/skia-dev/glog
> > > 
> > > Or more generally:
> > > 
> > > go get -u go.skia.org/infra
> > 
> > Now I get,
> > 
> > mtklein@linux ~/skia (extar)> git cl presubmit -u
> > Running presubmit upload checks ...
> > ../src/go.skia.org/infra/go/isolate/isolate.go:20:2: cannot find package
> > "cloud.google.com/go/storage" in any of:
> > 	/usr/lib/go/src/cloud.google.com/go/storage (from $GOROOT)
> > 	/home/mtklein/src/cloud.google.com/go/storage (from $GOPATH)
> > ../src/go.skia.org/infra/task_scheduler/go/db/task.go:16:2: cannot find
> package
> > "github.com/luci/luci-go/common/api/swarming/swarming/v1" in any of:
> > 	/usr/lib/go/src/github.com/luci/luci-go/common/api/swarming/swarming/v1
(from
> > $GOROOT)
> > 	/home/mtklein/src/github.com/luci/luci-go/common/api/swarming/swarming/v1
> (from
> > $GOPATH)
> > ../src/go.skia.org/infra/task_scheduler/go/db/memory.go:11:2: cannot find
> > package "github.com/satori/go.uuid" in any of:
> > 	/usr/lib/go/src/github.com/satori/go.uuid (from $GOROOT)
> > 	/home/mtklein/src/github.com/satori/go.uuid (from $GOPATH)
> > ../src/go.skia.org/infra/go/gs/testing.go:16:2: cannot find package
> > "google.golang.org/api/option" in any of:
> > 	/usr/lib/go/src/google.golang.org/api/option (from $GOROOT)
> > 	/home/mtklein/src/google.golang.org/api/option (from $GOPATH)
> > 
> > ** Presubmit ERRORS **
> > `go run infra/bots/gen_tasks.go --test` failed:
> > 
> > 
> > Presubmit checks took 3.6s to calculate.
> 
> That's after a "go get -u go.skia.org/infra/..." ?

Yes.

[borenet, 2016-10-04 23:13:46]

That's weird. That command should update the infra repo and all of its
dependencies. I guess there weren't any errors running "go get"?

[mtklein, 2016-10-04 23:32:07]

On 2016/10/04 23:13:46, borenet wrote:
> That's weird. That command should update the infra repo and all of its
> dependencies. I guess there weren't any errors running "go get"?

Don't think so.  As I recall it just quietly ran for about 25 seconds and then
exited without printing anything.

I'll give it another run tomorrow and let you know if I see anything.